Troubleshooting a package hoisting issue during a Sanity upgrade

Huh, just upgraded Sanity version and got this. Any ways around this?

Hi Toms. Could you please try deleting your

node_modules

folder, installing with yarn or npm, and then trying

sanity start

once more?

Tried that, didn't help.Tried that + removing yarn.lock, didn't help.


😞

Tried that, didn't help.Tried that + removing yarn.lock, didn't help.


😞

Okay, this is a monorepo and this probably doesn't help it:

For whatever reason, the package hasn't been fully hoisted.

Does

yarn list styled-components

show different versions between the top-level styled-components and the one used by

@sanity/base

?

Does

yarn list styled-components

show different versions between the top-level styled-components and the one used by

@sanity/base

?

E.g.,

nop, yarn list only shows one, the "hoisted one"

am already following this guide here: https://styled-components.com/docs/faqs#why-am-i-getting-a-warning-about-several-instances-of-module-on-the-page

because noticed in console that being the first warning:

im not using styled components myself, it's all just Sanity stuff

Did you upgrade to 2.17.1? Do you happen to recall the previous version you were on?

I upgraded to 2.17.1, yes.

1.x something previously, rather old system

Ahh, perfect. Thank you. I have to go out for a bit but will keep trying to replicate and troubleshoot when I get back.

Much appreciated, gotta deploy on monday, lol. 😄

will revert for the time being as im blocked 😞

Unfortunately, I haven’t been able to replicate the error. I used the Commerce Layer monorepo to try and emulate your setup—starting on 1.150.8 and upgrading to 2.17.1. I’ll ask the team for some advice and recognize that the upgrade is on a deadline.

I’ve been able to replicate your error now, by manually adding styled-components@5.1.0 to the studio folder. I could then solve it by removing styled-components or upgrading it to the same version as what’s being used by the @sanity packages. Based on your screenshots of previous efforts I’m still not entirely sure how to solve this, since your setup doesn’t appear to have that same duplication. I’m admittedly no expert with modules but perhaps you could search your lock file for styled-components and see if there’s another version somewhere.

Oh, you know what else is specific to my env, my monorepo has two studio installations.

Oh, you know what else is specific to my env, my monorepo has two studio installations.

Both of them were in the same version though.

While reverting I didn't save ones package.json so one was on 1.x and the other in 2.x, that worked.

But I'm not so sure if they both were the exact same version, maybe I messed up somewhere.

So while the two were on different versions it worked? Or it works now?

On different worked

On different worked

As only one of them had the new UI

On different worked

If both are on 2.17.1 and you install styled-components ^5.2.1, does that work?

I'll get back to you when I have time to test. Thanks for your time already!

I'll get back to you when I have time to test. Thanks for your time already!

Hi Toms. I just wanted to follow up and see how things are going with this. I believe a fix should be available on the next release to resolve this issue with yarn/npm’s occasional reluctance to properly hoist packages, and wanted to let you know so you can keep an eye out.

Oh, great news! I've been busy with other stuff and haven't invested any more time to upgrade. Still on 1.150.8ish.

You got PR to link so I can see what's the fix like?

I believe these cover it:
•
https://github.com/sanity-io/sanity/commit/b2e0d92ded14321273831a761f7e37d6b7caf128 •
https://github.com/sanity-io/sanity/commit/417c783d5fb80afc380454f3ecf9562223fc4565 •
https://github.com/sanity-io/sanity/commit/d06bbfe747ffa9a436efc17cb701cb77d11de54f

thanks! subscribed to releases

Hi Toms. This will hopefully be resolved by 2.19.0, just released.

Hey, a bit late, but I just upgraded my sanity instances and it all works now, thanks!

Awesome! Thanks for letting us know! 🙌